deploy on node 18

[chris48s]

Refs #9297
Refs #9323

Node 16 will reach EOL and stop getting security patches on 11 Sep 2023. I've been running my local dev copy with node 18 on and off recently and not noticed any problems. We've also been running the tests on node 18 in CI for ~a month

I would like to get #9323 reviewed and merged ahead of this one because once we upgrade to node 18, the default npm version is npm 9. Requiring contributors to use node 18 but requiring an old npm version and providing a v2 lockfile is a bit of a crap contributor experience. done + updated

Alternatively, I could smoosh those changes into this PR too.

TODO: update branch protection rules when we merge

• 16 + 18 package lib tests have changed due to engine-strict true/false
• remove main-18, integration-18, services-18
• add main-20, integration-20, services-20

[github-actions]

	Messages
📖	✨ Thanks for your contribution to Shields, @chris48s!
📖	Thanks for contributing to our documentation. We ❤️ our documentarians!

Generated by 🚫 dangerJS against 2b735e3

[github-actions]

🚀 Updated review app: https://pr-9385-badges-shields.fly.dev

[github-actions]

🚀 Updated review app: https://pr-9385-badges-shields.fly.dev

[PyvesB]

This still uses Node 16, shall we update it as well whilst we're at it?

shields/.github/actions/close-bot/action.yml

Line 11 in 7d966ab

using: 'node16'

[jNullj]

Shouldn't badge-maker/package.json also get updated to node 18?

[chris48s]

This still uses Node 16, shall we update it as well whilst we're at it?

node16 is the highest supported runner for javascript actions. The next jump will be to 20. See actions/runner#2704

Fortunately, keeping this in sync with the rest of the codebase doesn't really matter as none of the application code is run by this action. Only the files in https://github.com/badges/shields/tree/master/.github/actions/close-bot

Shouldn't badge-maker/package.json also get updated to node 18?

Badge-maker is a package which is used by other applications as well as shields.io, so we try to test against a fairly wide range of node versions (that range needs to include whatever major node version we deploy shields.io on, but ideally it is as wide as we can make it without jumping through too many hoops). At the moment, badge-maker is tested on Node 16, 18 and 20. There's no need to drop compatibility with node 16 for now so >=16 is the right range.

[PyvesB]

Looks good to me! 👍🏻