Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy on node 18 #9385

Merged
merged 7 commits into from
Aug 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/danger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
with:
node-version: 16
node-version: 18

- name: Danger
run: npm run danger ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/deploy-docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
with:
node-version: 16
node-version: 18

- name: Build
run: npm run build-docs
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-bug-run-badge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
with:
node-version: 16
node-version: 18
cypress: false

- name: Output debug info
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
with:
node-version: 16
node-version: 18
cypress: true

- name: Run tests
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Integration@node 18
name: Integration@node 20
on:
pull_request:
types: [opened, reopened, synchronize]
Expand All @@ -8,7 +8,7 @@ on:
- 'dependabot/**'

jobs:
test-integration-18:
test-integration-20:
runs-on: ubuntu-latest
env:
PAT_EXISTS: ${{ secrets.GH_PAT != '' }}
Expand All @@ -35,7 +35,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
with:
node-version: 18
node-version: 20
env:
chris48s marked this conversation as resolved.
Show resolved Hide resolved
NPM_CONFIG_ENGINE_STRICT: 'false'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
with:
node-version: 16
node-version: 18

- name: Integration Tests (with PAT)
if: ${{ env.PAT_EXISTS == 'true' }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
with:
node-version: 16
node-version: 18

- name: ESLint
if: always()
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Main@node 18
name: Main@node 20
on:
pull_request:
types: [opened, reopened, synchronize]
Expand All @@ -8,7 +8,7 @@ on:
- 'dependabot/**'

jobs:
test-main-18:
test-main-20:
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand All @@ -17,7 +17,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
with:
node-version: 18
node-version: 20
env:
NPM_CONFIG_ENGINE_STRICT: 'false'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
with:
node-version: 16
node-version: 18

- name: Core tests
uses: ./.github/actions/core-tests
4 changes: 2 additions & 2 deletions .github/workflows/test-package-lib.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ jobs:
matrix:
include:
- node: '16'
engine-strict: 'true'
- node: '18'
engine-strict: 'false'
- node: '18'
engine-strict: 'true'
- node: '20'
engine-strict: 'false'
steps:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Services@node 18
name: Services@node 20
on:
pull_request:
types: [opened, edited, reopened, synchronize]
Expand All @@ -7,7 +7,7 @@ on:
- 'gh-readonly-queue/**'

jobs:
test-services-18:
test-services-20:
runs-on: ubuntu-latest

steps:
Expand All @@ -17,7 +17,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
with:
node-version: 18
node-version: 20
env:
chris48s marked this conversation as resolved.
Show resolved Hide resolved
NPM_CONFIG_ENGINE_STRICT: 'false'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-services.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
with:
node-version: 16
node-version: 18

- name: Service tests (triggered from local branch)
if: github.event.pull_request.head.repo.full_name == github.repository
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-github-api.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Setup
uses: ./.github/actions/setup
with:
node-version: 16
node-version: 18

- name: Check for new GitHub API version
run: node scripts/update-github-api.js
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:16-alpine AS Builder
FROM node:18-alpine AS Builder

RUN mkdir -p /usr/src/app
RUN mkdir /usr/src/app/private
Expand All @@ -19,7 +19,7 @@ RUN npm prune --production
RUN npm cache clean --force

# Use multi-stage build to reduce size
FROM node:16-alpine
FROM node:18-alpine

ARG version=dev
ENV DOCKER_SHIELDS_VERSION=$version
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ You can read a [tutorial on how to add a badge][tutorial].

## Development

1. Install Node 16 or later. You can use the [package manager][] of your choice.
Tests need to pass in Node 16 and 17.
1. Install Node 18 or later. You can use the [package manager][] of your choice.
Tests need to pass in Node 18 and 20.
2. Clone this repository.
3. Run `npm ci` to install the dependencies.
4. Run `npm start` to start the badge server and the frontend dev server.
Expand Down
2 changes: 1 addition & 1 deletion doc/TUTORIAL.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ and learn about the [GitHub workflow](http://try.github.io/).

#### Node, NPM

Node >=16 and NPM 9.x is required. If you don't already have them,
Node >=18 and NPM 9.x is required. If you don't already have them,
install node and npm: https://nodejs.org/en/download/

### Setup a dev install
Expand Down
4 changes: 2 additions & 2 deletions doc/self-hosting.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ This document describes how to host your own shields server either from source o

## Installing from Source

You will need Node 16 or later, which you can install using a
You will need Node 18 or later, which you can install using a
[package manager][].

On Ubuntu / Debian:

```sh
curl -sL https://deb.nodesource.com/setup_16.x | sudo -E bash -; sudo apt-get install -y nodejs
curl -sL https://deb.nodesource.com/setup_18.x | sudo -E bash -; sudo apt-get install -y nodejs
```

```sh
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
"pretest": "cross-env BASE_URL=http://localhost:8080 run-s --silent defs",
"test": "run-s --silent --continue-on-error lint test:package test:core test:entrypoint check-types:package prettier:check",
"check-types:package": "tsd badge-maker",
"depcheck": "check-node-version --node \">= 16.0\"",
"depcheck": "check-node-version --node \">= 18.0\"",
"prebuild": "run-s --silent depcheck",
"defs": "node scripts/export-openapi-cli.js",
"build": "rimraf public && run-s defs docusaurus:build",
Expand Down Expand Up @@ -212,7 +212,7 @@
"url": "^0.11.1"
},
"engines": {
"node": "^16.13.0",
"node": "^18.16.0",
"npm": "^9.0.0"
},
"type": "module",
Expand Down
Loading