Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(endpoint-badge): add logoSize support; test [endpoint] #10132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LitoMore
Copy link
Contributor

@LitoMore LitoMore commented May 2, 2024

Currently, the endpoint badge response schema does not support logoSize parameter.

Copy link
Contributor

github-actions bot commented May 2, 2024

Messages
📖 ✨ Thanks for your contribution to Shields, @LitoMore!

Generated by 🚫 dangerJS against d1c8667

github-merge-queue bot pushed a commit to jsr-io/jsr that referenced this pull request May 8, 2024
The JSR logo has been added to Simple Icons since
simple-icons/simple-icons#10794.

I used the `logoSize` parameter to make the logo fit the badge. The
feature was introduced at badges/shields#9191.

Currently, we can't use `logoSize` in the response due to
badges/shields#10132. So I passed these
parameters with search parameters instead.
github-merge-queue bot pushed a commit to jsr-io/jsr that referenced this pull request May 9, 2024
The JSR logo has been added to Simple Icons since
simple-icons/simple-icons#10794.

I used the `logoSize` parameter to make the logo fit the badge. The
feature was introduced at badges/shields#9191.

Currently, we can't use `logoSize` in the response due to
badges/shields#10132. So I passed these
parameters with search parameters instead.
@chris48s chris48s changed the title feat(endpoint-badge): add logoSize support feat(endpoint-badge): add logoSize support; test [endpoint] May 20, 2024
Copy link
Contributor

🚀 Updated review app: https://pr-10132-badges-shields.fly.dev

@chris48s
Copy link
Member

Can you have a look at getting your test passing?

This needs to either

  • Call .json?... and make an assertion about the response object
  • Call .svg?... and make an assertion about the xml

<tr>
<td><code>logoSize</code></td>
<td>
Default: none. Make icons adaptively resize by setting auto.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Default: none. Make icons adaptively resize by setting auto.
Default: none. Make icons adaptively resize by setting <code>auto</code>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants