Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snapcraft] license #10520

Merged
merged 4 commits into from
Sep 15, 2024
Merged

[Snapcraft] license #10520

merged 4 commits into from
Sep 15, 2024

Conversation

davide-pi
Copy link
Contributor

@davide-pi davide-pi commented Sep 11, 2024 •
edited
Loading

ISSUE: #10299

Add Snapcraft license.
Create the SnapcraftBase from which other Snapcraft services can inherit.

Update Snapcraft version service to inherit from the SnapcraftBase.

Add Snapcraft base URL in configurations.

@davide-pi
Add snapcraft license. Update snapcraft version to inherit from snapc…
5eb6985 
…raft-base class. Add snapcraft base url in configurations.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 11, 2024 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @davide-pi!

Generated by 🚫 dangerJS against 975a69b

@davide-pi davide-pi mentioned this pull request Sep 12, 2024
Open
chris48s
chris48s reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@chris48s chris48s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks pretty solid. Just one thing needing to follow up

config/default.yml Outdated Show resolved Hide resolved
@chris48s chris48s added the service-badge Accepted and actionable changes, features, and bugs label Sep 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 Updated review app: https://pr-10520-badges-shields.fly.dev

@chris48s chris48s added this pull request to the merge queue Sep 15, 2024
Merged via the queue into badges:master with commit eca1b28 Sep 15, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris48s chris48s chris48s approved these changes

Assignees
No one assigned
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davide-pi @chris48s