Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jenkins] Use old.stats.jenkins.io for JSON data #10522

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

Copy link
Contributor

Warnings
⚠️ This PR modified service code for jenkins but not its test code.
That's okay so long as it's refactoring existing code.
Messages
📖 ✨ Thanks for your contribution to Shields, @froque!

Generated by 🚫 dangerJS against 77f66e9

@lemeurherveCB
Copy link

@chris48s
Copy link
Member

chris48s commented Sep 12, 2024

Obviously I can see that
https://old.stats.jenkins.io/plugin-installation-trend/view-job-filters.stats.json serves some JSON
and
https://stats.jenkins.io/plugin-installation-trend/view-job-filters.stats.json
is a 404

but what's the long-term goal here?

Is the situation that the new https://stats.jenkins.io site still provides this data, but we need to account for some breaking changes? If so, lets do that.

If https://stats.jenkins.io just removes access to this data and old.stats.jenkins.io will only be around for a short time, lets sunset this following the deprecation process.

To me, it looks like the second one. While it does seem to be possible to initiate a download of JSON data via javascript in a browser, it seems to me like there is now no obvious or documented way to do this via a call to a predictable URL.

@lemeurherveCB
Copy link

lemeurherveCB commented Sep 12, 2024

As there are far more consumers than we initially though (https://github.com/search?q=stats.jenkins.io&type=code 😱), I'll open an issue on the new frontend project and/or Jenkins infra helpdesk to determine how/if we can continue to serve those files without breaking existing URLs. (No ETA yet, to be discussed first)

I'll keep you informed.

EDIT: proposed a potential solution (redirections) at jenkins-infra/helpdesk#4132 (comment)

@lemeurherveCB
Copy link

FWIW, the current data is still available at https://github.com/jenkins-infra/infra-statistics/tree/gh-pages/plugin-installation-trend. (Note: we'll change the branch from gh-pages to data soon.)

@lemeurherveCB
Copy link

Sorry for the inconvenience, I'm at fault here I should have searched for external consumers earlier.

@chris48s
Copy link
Member

chris48s commented Sep 13, 2024

OK. Thanks. For the moment I am going to merge this as a stop-gap but I'll make an issue for the follow up

@chris48s chris48s added this pull request to the merge queue Sep 13, 2024
@chris48s chris48s added the service-badge Accepted and actionable changes, features, and bugs label Sep 13, 2024
Merged via the queue into badges:master with commit 394a827 Sep 13, 2024
24 checks passed
chris48s added a commit to chris48s/shields that referenced this pull request Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service-badge Accepted and actionable changes, features, and bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants