try catch finally sendBadge

[RedSparr0w]

Move the sendBadge(format, badgeData); functions inside of finally blocks,
Don't know if there will be any performance differences, but should minimize the code base slightly.

[paulmelnikow]

Hey, wanted to say I'm willing to review this if you feel strongly about it.

I've been pushing back for a while on refactoring server.js, since we're about to rewrite all the services as they get broken out into separate modules a la #963. It uses async/await and the handlers return badgeData which basically means the existing logic will be used, but none of the existing structure.

Did you follow that PR? Now that it's merged we ought to open an issue to start discussing how to approach the rewrite. I did make a project but it doesn't have anything useful on it yet.

What are your thoughts?

[RedSparr0w]

Ah, completely forgot about that!
No worries, will close this PR.
Will be good to get that going, and a great time to add the currently missing tests too.

[paulmelnikow]

Thanks for understanding! And agreed!