Add Github package.json dependency version badge; affects [githubpackagejson githubmanifest npm] #2709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ejson githubmanifest npm] Close #2259 which is mostly about a `package.json` dependency badge.
paulmelnikow
added
the
service-badge
|
paulmelnikow
changed the title
3 tasks
| } else if (kind === 'prod') { | ||
| dependenciesOfKind = dependencies | ||
| } else { | ||
| throw Error(`Not very kind: ${kind}`) |
There was a problem hiding this comment.
😆 The only time this would get hit is if a service accepts and/or passes along a bad dependency kind here right?
There was a problem hiding this comment.
Thought I responded to this before. Yes! That would be a programmer error.
There was a problem hiding this comment.
Okay cool. Just wanted to make sure we weren't planning on surfacing this message up to end users
👍
There was a problem hiding this comment.
If it got thrown in production, they'd see shields internal error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2259 which is mostly about a
package.jsondependency badge.Requires #2644.