Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor service loader; test on [static dynamic endpoint] #2861

Merged
merged 4 commits into from
Jan 25, 2019
Merged

Refactor service loader; test on [static dynamic endpoint] #2861

merged 4 commits into from
Jan 25, 2019

Conversation

paulmelnikow
Copy link
Member

This moves the loader code into core/base-service, leaving behind in services/index.js only the convenience imports.

Ref #2832

@paulmelnikow
Refactor service loader; test on [static dynamic endpoint]
f529ed7 
This moves the loader code into `core/base-service`, leaving behind in `services/index.js` only the convenience imports.

Ref #2832
@paulmelnikow paulmelnikow added core Server, BaseService, GitHub auth blocker PRs and epics which block other work labels Jan 24, 2019
@shields-ci
Copy link

shields-ci commented Jan 24, 2019 •
edited
Loading

Messages
📖 ✨ Thanks for your contribution to Shields, @paulmelnikow!

Generated by 🚫 dangerJS against 33c5279

@paulmelnikow paulmelnikow mentioned this pull request Jan 24, 2019
Closed
5 tasks
@paulmelnikow paulmelnikow temporarily deployed to shields-staging-pr-2861 January 24, 2019 05:54 Inactive
@paulmelnikow paulmelnikow merged commit be7cb93 into master Jan 25, 2019
@shields-deployment
Copy link

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch:

@paulmelnikow paulmelnikow deleted the refactor-loader branch January 25, 2019 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris48s chris48s chris48s approved these changes

Assignees
No one assigned
Labels
blocker PRs and epics which block other work core Server, BaseService, GitHub auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulmelnikow @shields-ci @chris48s