Migrated [JenkinsPlugin] to new service architecture

[PyvesB]

See #2863.

[shields-ci]

	Messages
📖	✨ Thanks for your contribution to Shields, @PyvesB!

Generated by 🚫 dangerJS against 5341eed

[calebcartwright]

Wow you turned that around fast!

[calebcartwright]

Everything LGTM. The only question I have is around regularUpdate since the file containing it currently resides within the legacy directory hierarchy. If that helper will continue to be leveraged in the new service architecture, should that file (eventually) be moved to a different directory?

[paulmelnikow]

The only question I have is around regularUpdate since the file containing it currently resides within the legacy directory hierarchy. If that helper will continue to be leveraged in the new service architecture, should that file (eventually) be moved to a different directory?

I think regular-update needs a total rewrite using async/await. Caching code is notoriously difficult to test and so I'd rather base the cache part on node-cache.

If this is the last legacy service to use it, the time to rewrite may be upon us!

#3101 (comment)

[PyvesB]

Yes, I believe this is the last legacy service that is using regularUpdate.

[calebcartwright]

I think regular-update needs a total rewrite using async/await. Caching code is notoriously difficult to test and so I'd rather base the cache part on node-cache

Do we want to do that here as part of refactoring this service? Or should we go ahead and merge this and then in a follow on tackle rewriting regular-update (and updating this service accordingly)?

[paulmelnikow]

Think that can definitely be a follow-on.

[shields-deployment]

This pull request was merged to master branch. This change is now waiting for deployment, which will usually happen within a few days. Stay tuned by joining our #ops channel on Discord!

After deployment, changes are copied to gh-pages branch: