Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: [GithubCommitActivity] invalid branch error handling #9258

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Fix: [GithubCommitActivity] invalid branch error handling #9258

merged 2 commits into from
Jun 14, 2023

Commits on Jun 14, 2023

  1. Fix error handling of bad branch in [GithubCommitActivity] 

    When GraphQL response with a bad repo it returns an error indicating the bad repo.
When GraphQL has the currect repo with a bad branch it will null inside the repo object without an error object.
The privouse commits seems to try and use that but due not allowing null in schema it did not work and an error due to bad schema would show insted.

This commit fixes this issue
    @jNullj
    jNullj committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    cdec770 View commit details
    Browse the repository at this point in the history

  2. Add test for invalid branch in [GithubCommitActivity]

    @jNullj
    jNullj committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    c5411f7 View commit details
    Browse the repository at this point in the history