-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add [GitHubDiscussionsSearch] and GitHubRepoDiscussionsSearch service #9340
Add [GitHubDiscussionsSearch] and GitHubRepoDiscussionsSearch service #9340
Conversation
6f38564
to
7006a63
Compare
7006a63
to
c269340
Compare
Did a rebase to latest commit on master |
🚀 Updated review app: https://pr-9340-badges-shields.fly.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. This is basically done. Couple of comments but it is minor stuff
This commit adds a GitHub Discussions custom search service in the github-discussions-custom-search.service.js file. It includes classes for global discussions search (GithubDiscussionsSearch) and repository-specific discussions search (GithubRepoDiscussionsSearch). Users can now search discussions with custom queries and retrieve the discussion count. Fixes badges#9213
Inform users of filters and query values for the free search.
Change examples from filter by author to `filter` by `answered-by` as this has higher change of being a more common use case.
c269340
to
3fb024f
Compare
@chris48s about the name change, the tests for GitHubRepoDiscussionsSearch are wihthin the test files for GitHubDiscussionsSearch similar to how it is done with the issuesSearch. notice the error for the tester job at this line also did a rebase to latest commit at master |
🚀 Updated review app: https://pr-9340-badges-shields.fly.dev |
Yes. Sorry I hadn't clocked that This LGTM 👍 I will get it deployed over the weekend. Thanks |
Add GitHub Discussions custom search service
This commit adds a GitHub Discussions custom search service in the github-discussions-custom-search.service.js file. It includes classes for global discussions search (GithubDiscussionsSearch) and repository-specific discussions search (GithubRepoDiscussionsSearch). Users can now search discussions with custom queries and retrieve the discussion count.
Fixes #9213
TODO: