-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pelican3.7.0 #39
pelican3.7.0 #39
Conversation
Yes, it does appear to fix the problem. I tried it. There's still the (separate) _get_summary deprecation in Pelican 3.7, but that's unrelated. |
c156b40
to
9bee68a
Compare
@szhorvat I think this new version of the patch/pull request should remove the deprecation issue, which I fixed, tested, added, committed, then squashed the two commits together. I am absolutely certain you use this plugin more than I, so if you could test it and make sure it works that would be great. |
I tried it again. It appears to work fine both with Pelican 3.7.1 and 3.6.3. Thank you for the fix! |
Actually, I just noticed a problem. With the
setting, the usual script that enables MathJax doesn't get inserted into the output. This was not a problem with 3.6.3. |
To be more precise, it doesn't get inserted only on the summary pages. The blog post pages are fine. This is not due to the change you made, it doesn't work without that change either. I guess I should open a new bug for this. |
I opened #40 for this other problem. |
Thanks a lot for the PR! |
I believe this will fix #38 reported by @szhorvat.
I'm a bit of a noob to python, git, github, pelican, mathjax, but it seems to work and the unittest seem to work:
To get the unit tests to run in Python 2.7, I did have to make one change, which is not included here, to the import statement in render_math.py, removing the "." relative import.
this is, I temporarily changed
to