This repository has been archived by the owner on Mar 9, 2024. It is now read-only.
Removed all hacky OS specific code #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Okay I'll have to test this, but does this still finish directly? |
|
It doesn't wait for it to complete executing, and it doesn't kill it due to https://github.com/GrahamCampbell/laravel-async-queue/blob/improvement/src/AsyncProcess.php. |
|
This is the only way it would work at all for me on windows. |
|
I'm about to test this on my hhvm server too. I'll let you know if it works. |
|
Hmmm. It's generating the correct command to run, but not working on hhvm. I don't think this package ever worked on hhvm though, so I've not broken it, I've just fixed windows support. |
|
I tweaked it a bit to come to this: 7ed454f |
|
Yeh. I might send another pull later this week with another tweak after I've had some time to play around with this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is massively better than the hacks we had before.