Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Travis CI to Github actions #36

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ahmagdy
Copy link
Contributor

@ahmagdy ahmagdy commented Mar 5, 2021

Migrate build validation steps from Travis CI to Github actions.

I used two separate jobs for Linux and macOS instead of using matrix strategy as there is no docker by default in macOS. Therefore I can't run Postgres service, and I can't add a condition to exclude this service. Conditions are only supported for steps and not for services!

It's very annoying that I had to duplicate go build and test steps because there are no composite actions in Github yet. It's being tracked in actions/runner#646.

The workflow has been tested in https://github.com/ahmagdy/go-askme/actions/runs/627285467.

Copy link
Owner

@bashmohandes bashmohandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants