Mas i1121 passringdir #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The riak_kv_console:reip/1 function currently requires the node to be down but riak_core configuration to be available so that functions that rely on get_env will work. Want to allow for a riak_kv_console:reip/3 where the Ring directory and ClusterName can be passed in.
Make Cluster a function arg
check_lastgasp/1 is not required when node is down (e.g. when running riak_kv_console:reip_manual/1).
|
+1 |
martinsumner
added a commit
that referenced
this pull request
Dec 19, 2022
* Allow use of ring update functions without app The riak_kv_console:reip/1 function currently requires the node to be down but riak_core configuration to be available so that functions that rely on get_env will work. Want to allow for a riak_kv_console:reip/3 where the Ring directory and ClusterName can be passed in. * Update riak_core_ring_manager.erl Make Cluster a function arg * Remove lastgasp check if do_write_rigfile/2 check_lastgasp/1 is not required when node is down (e.g. when running riak_kv_console:reip_manual/1).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break down the functions required for reip, so that it can be called from riak_kv_console without knowledge of the cluster name or of the ring directory. This makes it easier to write a reip admin command to be used when riak_core is not loaded with its standard configuration