Fix broken CI pipeline #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it;'s fine to use latest xcode
| @@ -12,8 +12,8 @@ jobs: | |||
| runs-on: macos-latest | |||
| steps: | |||
| - uses: actions/checkout@v1 | |||
| - name: Select Xcode 12.2 | |||
| run: sudo xcode-select -s /Applications/Xcode_12.2.app | |||
| - name: Print Xcode version | |||
There was a problem hiding this comment.
Is this fixing something specific you're facing?
There was a problem hiding this comment.
Rarely but sometimes older versions get deprecated. E.g
Min version is 12.4 after this one.
There was a problem hiding this comment.
i believe this plugin has little dep on xcode and its implementations so it's fine to just rely on latest version for now until we face problems
There was a problem hiding this comment.
Discussed offline, see an example: https://github.com/bazel-ios/cocoapods-bazel/runs/4740577782?check_suite_focus=true
That said I'm ok with changing this for now and see how CI behaves
There was a problem hiding this comment.
Thx for sharing the example too @chenxiao0228!
chenxiao0228
approved these changes
Jan 10, 2022
thiagohmcruz
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it;'s fine to use latest xcode
broken CI: https://github.com/bazel-ios/cocoapods-bazel/runs/4740577782?check_suite_focus=true