-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for bindeps in crate universe #2226
Conversation
3fa018d
to
a11c989
Compare
I think this looks good! Just gotta fix up the new test and rebase 😄 |
bcd4293
to
63e560c
Compare
Ah, there's one more directory which needs to be repinned via crate_universe. Try running the following? cd ./test/no_std/ && REPIN=1 bazel query //... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Bah, thanks. Happy we were able to land this. Thanks all! |
Followup to #2226. That PR made bindeps work for crates repositories that use `manifests`. https://github.com/bazelbuild/rules_rust/blob/d86faee8b85cc334e0529193142f4b61362e79a3/examples/crate_universe/WORKSPACE.bazel#L60 This PR makes it work for crates repositories that use `packages`. https://github.com/bazelbuild/rules_rust/blob/43b101e6b3e679b333c2622d7615233edf344624/examples/crate_universe/WORKSPACE.bazel#L317-L320
Fixes #1739, #2031, #2168.