Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ruby/def.bzl + spelling + v0.1.2 #48

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

kigster
Copy link
Contributor

@kigster kigster commented Dec 19, 2019

Really small PR to remove confusing ruby/def.bzl that conflicts with ruby/defs.bzl (correct version), fix spelling and bump the version.

@kigster kigster requested a review from yugui as a code owner December 19, 2019 03:33
@kigster kigster self-assigned this Dec 19, 2019
@kigster kigster added the feature New feature or request label Dec 19, 2019
@kigster kigster added this to the M-0.1 milestone Dec 19, 2019
Copy link

@thundergolfer thundergolfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this technically requiring at least a minor version bump if it's removing a file that is loaded by end-users?

Are we following SemVer before 1.0.0?

@kigster
Copy link
Contributor Author

kigster commented Dec 19, 2019

This file should not be used by any endusers of this repository. It may have been used against the original repo that's under @yugui 's username. Version bump is completely symbolic at the moment.

@kigster kigster merged commit 6edcf32 into develop Dec 19, 2019
@kigster kigster deleted the kig/bump-version-0.1.2 branch December 19, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants