This PR refactors bundle steps and :bin generation #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kigster
force-pushed
the
kig/refactor-bundle-binaries
branch
from
8fe9073
to
27bcdd0
Compare
grahamjenson
reviewed
Jan 6, 2020
grahamjenson
reviewed
Jan 6, 2020
grahamjenson
reviewed
Jan 6, 2020
kigster
force-pushed
the
kig/refactor-bundle-binaries
branch
from
49e92b7
to
ecf0fc5
Compare
|
This was already reviewed, merging since I only updated with PR feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we add a
@bundle//bintarget consisting of all binaries + the limited list of gem dependencies that provide those binaries (instead of all binaries), thus enabling running of@bundle//bin/rubocopwith proper dependencies. We are also adding executable commands underbin/*to the sources of respective gems providing that executable.We also attempted to secure the order of bundle operations by passing the result of a previous macro/action to the next, in hopes to create a linear dependency graph. While this did not break things, it's unclear whether this actually accomplishes the desired affect. Leaving in, in case we could trigger the linear dependency of steps within rule's implementation by, perhaps, accessing each result in addition to passing it as a function argument to the next function.
You can reference individual gems as
@bundle//:gem-nameas before, and you can also pull in the entire bundle with@bundle//:gems.