-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy to Azure Static Web Apps is not reliable #110
Comments
Just found https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepscontinue-on-error but don't know if its a good fit here. I still want to see that the job failed, but I don't want to have the job as a required check. |
As StackOverflow described there were zombie environments from abandoned pull requests. I deleted those now. |
Right now we're on a free plan only allowing us 3 staging environments. If we switched to a paid plan that would be increased to 10. |
We can also decide that we will just live with this 🙃 Just wanted to note down and take a decision on a pain-point I see for maintaining the project. |
Looked a bit into this and decided to propose to add See #131. If we don't want it this way, I'd leave it and just accept that some PRs will have a red workflow-indicator in their listing for no code-related reason. |
Got a rework by @adelinn, now supports up to 10 instances |
Is there any way of not-having the job "Deploy to Azure Static Web Apps" report as a failing job - specially if the reason is:
This Static Web App already has the maximum number of staging environments (3). Please remove one and try again.
?It makes it hard to see which PRs actually require additional treatment (e.g. not according to linting rules or tests failing) and on which there's just a deploy-job failing...
The text was updated successfully, but these errors were encountered: