Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy solution for signing Windows .exe from bcc-code/bible-explorers #419

Merged
merged 8 commits into from
May 10, 2024

Conversation

kkuepper
Copy link
Member

@kkuepper kkuepper commented May 9, 2024

No description provided.

Copy link

github-actions bot commented May 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-419.westeurope.3.azurestaticapps.net

Copy link

github-actions bot commented May 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-419.westeurope.3.azurestaticapps.net

Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 8.74%. Comparing base (8cf8022) to head (ea8e3c2).
Report is 53 commits behind head on main.

❗ Current head ea8e3c2 differs from pull request most recent head 2fd6f08. Consider uploading reports for the commit 2fd6f08 to get more accurate results

Files Patch % Lines
electron_sign_exe.js 0.00% 24 Missing and 1 partial ⚠️
electron_builder.js 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #419      +/-   ##
========================================
- Coverage   8.77%   8.74%   -0.03%     
========================================
  Files        131     140       +9     
  Lines       7922    8128     +206     
  Branches     253     256       +3     
========================================
+ Hits         695     711      +16     
- Misses      7099    7281     +182     
- Partials     128     136       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-419.westeurope.3.azurestaticapps.net

Copy link

github-actions bot commented May 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-419.westeurope.3.azurestaticapps.net

Copy link

github-actions bot commented May 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-419.westeurope.3.azurestaticapps.net

Copy link

github-actions bot commented May 9, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-419.westeurope.3.azurestaticapps.net

Copy link
Member

@cs1m0n cs1m0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you could do is merging the two specifically-for-Windows steps together (Install AzureSignTool and Package the Electron app).
Otherwise, LGTM!

@kkuepper
Copy link
Member Author

@cs1m0n I think it's more readable as separate steps.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-419.westeurope.3.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-419.westeurope.3.azurestaticapps.net

@kkuepper kkuepper merged commit cf4158d into main May 10, 2024
11 checks passed
@kkuepper kkuepper deleted the feature/378_sign-exe branch May 10, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants