-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy solution for signing Windows .exe from bcc-code/bible-explorers #419
Conversation
Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-419.westeurope.3.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-419.westeurope.3.azurestaticapps.net |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #419 +/- ##
========================================
- Coverage 8.77% 8.74% -0.03%
========================================
Files 131 140 +9
Lines 7922 8128 +206
Branches 253 256 +3
========================================
+ Hits 695 711 +16
- Misses 7099 7281 +182
- Partials 128 136 +8 ☔ View full report in Codecov by Sentry. |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-419.westeurope.3.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-419.westeurope.3.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-419.westeurope.3.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-419.westeurope.3.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you could do is merging the two specifically-for-Windows steps together (Install AzureSignTool and Package the Electron app).
Otherwise, LGTM!
@cs1m0n I think it's more readable as separate steps. |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-419.westeurope.3.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-419.westeurope.3.azurestaticapps.net |
No description provided.