-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queue: Add reorder functionality #437
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good apart from the two things mentioned.
P.s. somehow the linter does not run on save in your setup or has different settings...
Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-437.westeurope.3.azurestaticapps.net |
Just one last change ... can you ensure in your test that the prop This is important as the player will otherwise rebuild the track. This might not be the case now, but I just want this as part of the spec so we can ensure it stays like this in the future. |
@SimonSimCity Should be done now 👍🏼 |
Perfect 🤩 Just the linter ... |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-437.westeurope.3.azurestaticapps.net |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-437.westeurope.3.azurestaticapps.net |
" | ||
class="flex cursor-pointer justify-between gap-2 rounded-xl px-3 py-2 transition-all duration-500 ease-out hover:bg-background-2" | ||
class="flex cursor-row-resize justify-between gap-2 rounded-xl px-3 py-2 transition-all duration-500 ease-out hover:bg-background-2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sifferhans @SimonSimCity I think it makes sense to use a different mouse cursor to indicate that it's movable.
I hope you agree with my commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good point!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I love it!
@sifferhans Feel free to merge
Fixes #189 (?)
I used the vue-draggable-plus, as vue-draggable-next doesn't have great TypeScript support, and seems not actively maintained.
CleanShot.2024-06-09.at.23.59.18.mp4