Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue: Add reorder functionality #437

Merged
merged 8 commits into from
Jun 11, 2024
Merged

Queue: Add reorder functionality #437

merged 8 commits into from
Jun 11, 2024

Conversation

sifferhans
Copy link
Collaborator

@sifferhans sifferhans commented Jun 9, 2024

Fixes #189 (?)

I used the vue-draggable-plus, as vue-draggable-next doesn't have great TypeScript support, and seems not actively maintained.

CleanShot.2024-06-09.at.23.59.18.mp4

Copy link
Collaborator

@SimonSimCity SimonSimCity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the two things mentioned.

P.s. somehow the linter does not run on save in your setup or has different settings...

plugins/mediaPlayer/mediaPlayer.ts Outdated Show resolved Hide resolved
components/media-player/MediaPlayerOpen.vue Outdated Show resolved Hide resolved
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-437.westeurope.3.azurestaticapps.net

@SimonSimCity
Copy link
Collaborator

Just one last change ... can you ensure in your test that the prop currentTrack does not trigger as changed when moving the track? I just want to have this also as part of the spec of the added functionality.

This is important as the player will otherwise rebuild the track. This might not be the case now, but I just want this as part of the spec so we can ensure it stays like this in the future.

@sifferhans
Copy link
Collaborator Author

@SimonSimCity Should be done now 👍🏼

@SimonSimCity
Copy link
Collaborator

Perfect 🤩 Just the linter ...

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-437.westeurope.3.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://kind-meadow-01b17e903-437.westeurope.3.azurestaticapps.net

"
class="flex cursor-pointer justify-between gap-2 rounded-xl px-3 py-2 transition-all duration-500 ease-out hover:bg-background-2"
class="flex cursor-row-resize justify-between gap-2 rounded-xl px-3 py-2 transition-all duration-500 ease-out hover:bg-background-2"
Copy link
Member

@kkuepper kkuepper Jun 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sifferhans @SimonSimCity I think it makes sense to use a different mouse cursor to indicate that it's movable.
I hope you agree with my commit.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, good point!

Copy link
Member

@kkuepper kkuepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I love it!
@sifferhans Feel free to merge

@sifferhans sifferhans merged commit 44752ac into main Jun 11, 2024
11 checks passed
@sifferhans sifferhans deleted the feature/reorder-queue branch June 11, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Queue: Allow the user to change the order of the items
3 participants