-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added e2e testing #58
Conversation
Use `pnpm build:prod && pnpm preview` instead
I added the 2 secrets. |
Codecov Report
@@ Coverage Diff @@
## main #58 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 71 71
Branches 5 5
=========================================
Hits 71 71 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -0,0 +1,37 @@ | |||
/// <reference types="cypress" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this file be committed? Looks like a left-over
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't yet fully understood what the code-examples here are for - they're provided by the code generator. I'd commit it as part of understanding of what we can do, but I don't have any strong opinion on this ... What would you say is better?
Btw, the first line is a so-called triple-slash directive
Following cypress best practices
It seems like within github-actions, we have a problem reaching out to |
Problem referenced previously (regarding Videos and screenshots of tests are from now on available as artifacts on this project (!to everyone!). Steps for typing in credentials or confidential data should have the option |
Added a foundation of e2e testing. Please give feedback!
How variables can be set can be found here: https://docs.cypress.io/guides/guides/environment-variables#Setting
I've added the two currently in use (
USERNAME
andPASSWORD
) already to the github-script which should already work correctly after setting 'em up.The
build_and_test
job fails because of the missing credentials.We should also address here if we want the project to deploy if the e2e tests are failing due to a shift in data (e.g. test-data is not available as expected) or if the login service is unavailable or doesn't let us pass for other reasons.