Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LibrePGP PreferredEncryptionModes signature subpacket #1743

Merged
merged 8 commits into from
Sep 13, 2024

Conversation

vanitasvitae
Copy link
Contributor

@vanitasvitae vanitasvitae commented Jul 17, 2024

I decided to implement this in its own dedicated class to express that this is not an official OpenPGP signature subpacket.

@vanitasvitae
Copy link
Contributor Author

vanitasvitae commented Aug 26, 2024

This PR now includes changes from #1464

Edit: The codebase still contains these two methods, which are broken:

These methods take/return a single int[] as algorithms and store/retrieve those in a signature subpacket with packet ID 39 (OpenPGP).
This is a mix of LibrePGP- and OpenPGP-style AEAD preferences.

For now I have marked these methods as broken and deprecated, but really I'd rather remove them completely.
What do you think?

@hubot hubot merged commit fb24843 into bcgit:main Sep 13, 2024
@vanitasvitae vanitasvitae deleted the librePgpEncryptionModes branch September 17, 2024 12:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants