feat(FSADT1-1397): Backend Fuzzy matching on Business Information for BC Registered Business #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulushcgcj
requested review from
fterra-encora and
mamartinezmejia
as code owners
|
|
…ace separator should not be used"
|
mamartinezmejia
approved these changes
Aug 7, 2024
paulushcgcj
added a commit
that referenced
this pull request
Aug 16, 2024
… BC Registered Business (#1065) * feat(FSADT1-1397): renamed cases for registered * fix(FSADT1-1397): added missing cors header * test(FSADT1-1397): added more test util * test(FSADT1-1397): refactored test and added name * test(FSADT1-1397): refactored test and added name * test(FSADT1-1397): added missing test cases * feat(FSADT1-1397): added registered business match * chore: re-enabling match * test: updating tests * chore: updating code * chore: updating stubs * chore: updating validation and test * chore: fixing typo * fix: Fixed the following issue: "Legacy key/value format with whitespace separator should not be used" --------- Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca>
This was referenced Aug 16, 2024
Closed
paulushcgcj
added a commit
that referenced
this pull request
Aug 30, 2024
* Steal Paulo's work for this PR * Drop ImageStream and PROMOTE param * Replace DeploymentConfig with Deployment * Restore deployment strategy - recreate * Use local Dockerfile and non-root user for Compose * chore(deps:Snyk): Upgrade aws-amplify from 6.3.3 to 6.3.5 (#1020) fix: upgrade aws-amplify from 6.3.3 to 6.3.5 Snyk has created this PR to upgrade aws-amplify from 6.3.3 to 6.3.5. See this package in npm: aws-amplify See this project in Snyk: https://app.snyk.io/org/bcgov/project/69fea770-c686-480b-a695-14a73f2a0b30?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <snyk-bot@snyk.io> * chore(deps:Snyk): Upgrade sass from 1.77.1 to 1.77.4 (#1024) fix: upgrade sass from 1.77.1 to 1.77.4 Snyk has created this PR to upgrade sass from 1.77.1 to 1.77.4. See this package in npm: sass See this project in Snyk: https://app.snyk.io/org/bcgov/project/69fea770-c686-480b-a695-14a73f2a0b30?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <snyk-bot@snyk.io> * chore(deps:Snyk): Upgrade cypress from 13.8.1 to 13.11.0 (#1023) fix: upgrade cypress from 13.8.1 to 13.11.0 Snyk has created this PR to upgrade cypress from 13.8.1 to 13.11.0. See this package in npm: cypress See this project in Snyk: https://app.snyk.io/org/bcgov/project/69fea770-c686-480b-a695-14a73f2a0b30?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <snyk-bot@snyk.io> * feat(be:FSADT1-1324): Changes in email templates (#1025) * feat(be:FSADT1-1324): Changes in email templates (#1026) * feat(be:FSADT1-1324): Changes in email templates * feat(be:FSADT1-1324): Changes in email templates * feat(FSADT1-1365): backend fuzzy match for locations (#1013) * feat(FSADT1-1363): adding new endpoint and cleaning old code * chore(FSADT1-1363): changing testcontainer for oracle changing it due to the issues with Mac M2 chip. Increased the timeout to allow the oracle instance to spin up properly * chore(FSADT1-1363): updating test data updating test data for oracle * feat(FSADT1-1363): fuzzy match for individuals initial commit with some of the heavy lifting. not final * chore(FSADT1-1363): adding temporary api auth this entry is temporary and it will be changed before final push * feat(FSADT1-1363): updated api auth to matches * chore(FSADT1-1363): refactoring matcher code Refactored the code to allow easy to use on next iterations * test(FSADT1-1363): adding tests * chore: code cleanup * feat(FSADT1-1363): setting flag to allow match endpoint to work * feat(FSADT1-1363): add fe stub * chore(FSADT1-1363): code refactor * chore(FSADT1-1363): updating oracle sql files * fix(FSADT1-1363): mergind and rebasing * fix(FSADT1-1363): fixed branch due to dto changes * test(FSADT1-1363): updating test * chore(FSADT1-1365): update on oracle sql files * chore(FSADT1-1365): adding temporary code * feat(FSADT1-1365): new endpoints added * feat(FSADT1-1365): updated search * test(FSADT1-1365): updated test * chore(FSADT1-1365): updated sql files * chore(FSADT1-1365): adding sorting and distinct * test(FSADT1-1365): fixing ordering * feat(FSADT1-1365): added location matcher * feat(FSADT1-1365): updated test cases * chore: updating sql for legacy * chore: removing validations from actions * chore: updating sql for legacy * chore: updating sql for legacy * chore: updating sql for legacy * fix: fixing test cases on sql file * Made code reviews * no message --------- Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com> Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca> * chore(deps:Snyk): Upgrade @carbon/icons-vue from 10.90.0 to 10.92.0 (#1022) fix: upgrade @carbon/icons-vue from 10.90.0 to 10.92.0 Snyk has created this PR to upgrade @carbon/icons-vue from 10.90.0 to 10.92.0. See this package in npm: @carbon/icons-vue See this project in Snyk: https://app.snyk.io/org/bcgov/project/69fea770-c686-480b-a695-14a73f2a0b30?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com> * feat(FSADT1-1342): Display why and who rejected a submission (#1027) * feat(FSADT1-1364): backend fuzzy match for contacts (#1028) * feat(FSADT1-1364): added contact search for staff * feat(FSADT1-1364): added contact match on backend * chore: updating match due to extra phone numbers * Gave format to the code * chore: updating exception * chore: updating exception --------- Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca> * fix(fe:FSADT1-1406): Changed the logic when the good standing indicat… (#1030) fix(fe:FSADT1-1406): Changed the logic when the good standing indicator is null * feat(FSADT1-1356): Create client for staff Step 2 - Locations (#1029) * add locations step base files * test: add component tests * style fix * test: add locations wizard step * add delivery information fields * test additional delivery information * remove restriction for unique address * initialize validation * validate the two delivery information inputs together * validate locations on next * make scrollToElementFn optional * style: lint fix code * fix delivery information error when returned to the step * remove unnecessary validation * fix province Quebec on stubs * test delivery information * test validation * test same name and same address validations * turn autocomplete attribute off on address fields * add new address fields * fix test * fix email validation * update test * fix tests * test: mock responses * add accordion to additional locations * limit amount of locations to 25 * update accordion title * focus new location * test max locations * fix test * test max locations to be 25 * test: remove async * feat(fe:FSADT1-1382): Added code for the dashboard empty state (#1032) * no message * Updated pictogram library * feat(fe:FSADT1-1382): Added code for the dashboard empty state * feat(FSADT1-1405): added feature flag config on deployment (#1031) * feat(FSADT1-1405): added feature flag config on deployment * chore(FSADT1-1405): added feature flag warn messages * docs: adding documentation to workflow * docs: added doc generation to the scheduled job * feat(FSADT1-1405): added feature flag config on deployment * feat(FSADT1-1405): updated deployment for frontend * chore: adding processor to codeql analysis * docs: updating readme * docs: updating doc generation * docs: updating pandoc job * docs: replacing readme with index * chore: fixing documentation move * chore: updating doc gen * chore: adding test code * chore: test commit * chore: removing test code * feat(FSADT1-1405): adding deployment to test and prod * chore(deps:Snyk): Upgrade @carbon/styles from 1.57.0 to 1.59.0 (#1021) fix: upgrade @carbon/styles from 1.57.0 to 1.59.0 Snyk has created this PR to upgrade @carbon/styles from 1.57.0 to 1.59.0. See this package in npm: @carbon/styles See this project in Snyk: https://app.snyk.io/org/bcgov/project/69fea770-c686-480b-a695-14a73f2a0b30?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com> * feat(fe:FSADT1-1382): Added code for the dashboard empty state (#1033) * feat(fe:FSADT1-1382): Added code for the dashboard empty state - Added missing line that was not in Figma * feat(fe:FSADT1-1382): Added code for the dashboard empty state - Made changes requested by Andrea * feat(fe:FSADT1-1382): Added code for the dashboard empty state - Made changes requested by Andrea * feat(FSADT1-1401): Create Textarea input component (#1034) * add the textarea component * add slot * add the notes input field with tooltip * test Textarea component * test notes in the locations * update location test * add notes validation * allow line breaks in the Notes field * feat: added user identification to logs (#1036) * feat(FSADT1-1404): first nations api (#1035) * feat(FSADT1-1404): first nations opendata endpoint * feat(FSADT1-1404): updating after rebase * feat(FSADT1-1404): updating address for first nation * chore: updating webclients * feat(FSADT1-1404): adding stub for first nation --------- Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com> * fix(FSADT1-1382): limited empty state to loaded (#1037) * chore(deps): update github actions all dependencies * feat(FSADT1-1383): Load ID types from the backend API (#1038) * Renamed api names as CamelCase is generally discouraged in REST API endpoint naming * Renamed api names as CamelCase is generally discouraged in REST API endpoint naming * feat(FSADT1-1383): Load ID types from the backend API * feat(FSADT1-1383): Load ID types from the backend API * Renamed api names as CamelCase is generally discouraged in REST API endpoint naming * Renamed api names as CamelCase is generally discouraged in REST API endpoint naming * Upgraded Cypress * Added stubs * Fixed test * Fixed test. Issue: Value was set as Canadian Passport therefore, there is no need to interact with the province * Fixed test * no message * no message * Revert "no message" This reverts commit 6f4b90b. * no message * Attempt to fix cypress test * Debugging test... * Attempt to fix cypress test * Attempt to fix cypress test * Attempt to fix cypress test * Reverted latest change * Attempt to fix cypress test * no message * fix: fixing component test * Moved enpoints to the codes controller * Added IDIR roles in addresses API authorization * Moved enpoints to the codes controller * Cleaned up code * Improved and cleaned code * Cleaned up code. Fixed stubs. --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@gov.bc.ca> * feat(FSADT1-1347): create client for staff Step 3 - Contacts (#1040) * feat(FSADT1-1347): create client for staff Step 3 - Contacts (#1041) * chore: updating tsconfig * feat(FSADT1-1347): updated dto and functions * chore: updated locations and components * feat(FSADT1-1347): contact for staff page * chore(deps): updated cypress dependency * chore: updated components * chore: removing debug info * fix: updating contact components for staff * chore: updated text input component * feat(FSADT1-1347): added validation to contact * test(FSADT1-1347): adding tests to staff contact * test: updating tests * fix: fixing component test * Fixed endpoints in new form * Made more code reviews --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@gov.bc.ca> * fix(fe): Aligned FE validation with BE validation as per agreement (#1042) * feat(FSADT1-1347): create client for staff Step 3 - Contacts (#1043) * Fixed missing asterisk in mandatory fields * fix(FSADT1-1347): fixing validation missing value --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@gov.bc.ca> * feat(fe:FSADT1-1350): Create client for staff Step 4 - Review (#1044) * feat(fe:FSADT1-1350): Create client for staff Step 4 - Review * feat(fe:FSADT1-1385): Create the "Client created" page for staff (#1045) * feat(fe:FSADT1-1385): Create the "Client created" page for staff * no message * Improved code * Beautified code * no message * feat(fe:FSADT1-1389): Create client for staff - no selection (#1046) * feat(fe:FSADT1-1389): Create client for staff - no selection * feat(FSADT1-1366): Process Staff Submission (#1047) * feat(FSADT1-1366): updating dto and entity * feat(FSADT1-1366): added controller and updated query - Updated query to not load the SDD data. - Added the controller to allow staff submission * chore: updating log * feat(FSADT1-1366): updated district loading Updated district loading to avoid loading empty values. This is for staff submitted data. * feat(FSADT1-1366): updated name splitting for new individual * feat(FSADT1-1366): updated internal processor for staff Staff submitted data differs a little bit from external submission, so a few points in the code required some updates. * test(FSADT1-1366): added and updated tests to staff submission * feat(FSADT1-1366): added error handling for staff submission * feat(FSADT1-1366): updating mapper * chore(deps:FSADT1-1366): added reactor extra dependency * chore: updating objects * feat(FSADT1-1366): updating and adding validators * feat(FSADT1-1366): added retry util This is to accommodate the retry code * test(FSADT1-1366): principal util tests * feat(FSADT1-1366): removing old validation format * chore(FSADT1-1366): updating client mapper * test(FSADT1-1366): updating matcher test * feat(FSADT1-1366): adding staff submission * test: updating some tests * chore: updating models * test(FSADT1-1366): added test to validators * fix(FSADT1-1366): fixed validators * chore: preventing district email on test * test: fixing tests * chore: removed logs * chore: added missing parameters * chore: changed stub for email * chore: updated log configuration for test * test(FSADT1-1366): added tests to staff submission * chore: removed todo * feat(FSADT1-1366): set security mechanism for staff submission * chore: set the correct principal for staff * feat(FSADT1-1366): added request to processor from backend * fix: fixing build pattern for tests * chore: changing processor health * chore: updated deployment order * chore: updated controller error * feat(FSADT1-1366): added retry trigger for staff submission - added a new scheduled to handle retry triggered by staff submitted data - small change on the timing display to make it easier to read * feat(FSADT1-1366): added stub for staff submission for individual * fix(FSADT1-1366): fixing test and conversions * Gave format to the code * chore: setting test order * test: fixing test * test: fixing test * test: fixing tests * test: fixing tests --------- Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca> * feat(fe:FSADT1-1402): Create client for staff Step 1 - Individuals - capturing other ID (#1049) * feat(fe:FSADT1-1402): Create client for staff Step 1 - Individuals - capturing other ID * feat(FSADT1-1384): Submit data to create client by staff user (#1050) * fix: removing clientNumber from submitted * chore: reworked the app startup to consider route init wrapped the app to the router initialization, to make sure the router is ready before the application starts * chore: refactored stubs * chore: removed unsuded param from wiremock * feat(FSADT1-1384): simplified confirmation data * chore: removing unnecessary constants * feat(FSADT1-1384): added processing info on review page * chore: updating stubs * fix(FSADT1-1384): update be to send submission id * feat(FSADT1-1384): added staff processing route * feat(FSADT1-1384): added loading overlay * feat(FSADT1-1384): updating processing page * test: fixex test due to constant removed * test(FSADT1-1384): tests added to new components and pages * feat(FSADT1-1384): updated form staff for submission * Update SubmissionReviewPage.vue * test(FSADT1-1384): test review page with refresh for staff * test(FSADT1-1384): added tests to staff submission * chore: set label class for readonly input text * fix: fixed other id layout * test: updated tests * test: fixing data * text: fixing test * test: updating cypress tests for frontend * chore: removing tests for now * chore: updated files * test: adding delay before check * chore: ignoring report path for vite --------- Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com> * fix: small adjustments (#1051) * fix: added missing cors header * fix: fixed text * fix: fixed metrics endpoint for processor * fix: fixed location name case * feat(be:FSADT1-1420): Email generated from staff creation of client number * Sanittized phone numbers before persisting data * test: fixed test cases * fix: fixed some of the error handling and test * test: adding contactGroupComponent test back * test: adding test back --------- Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca> * fix(be): Removed logic from Legacy and placed it in the Processor (#1052) Removed logic from Legacy and placed it in the Processor * fix(fe:FSADT1-1414): Left menu active status (#1053) * fix(be:FSADT1-1419): Client ID is not being saved (#1054) * fix(be:FSADT1-1419): Client ID is not being saved * fix: staff contact validation (#1055) * fix validations * update message --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@gov.bc.ca> * fix(fe:FSADT1-1423): Hide left menu when the user is at the confirmat… (#1057) * fix(fe:FSADT1-1423): Hide left menu when the user is at the confirmation page * Made a better approach * fix(FSADT1-1422): added the missing middle name (#1058) * fix(FSADT1-1425): fixed mapping issues for external (#1059) External users provide empty fields for some staff related data, and this was causing some constraing issues. * feat: add fuzzy matching notification (#1060) * feat: add fuzzy matching notification * test: fix tests to wait the fuzzy matching delays * fix: removing fuzzy match (#1063) * fix(FSADT1-1428): fixed email not beint sent (#1064) * fix(FSADT1-1428): fixed district load on processor * chore(FSADT1-1828): added retry on client number loading * fix(fe): Commenting this for now until the API for fuzzy match is done (#1066) Commeting this for now until the API in done * chore: removing validation (#1067) * fix(FSADT1-1363): added missing headers for cors (#1068) * fix(FSADT1-1426): fixed multi-address issue (#1061) in case of bc registry data with multiple addresses, we order to have the mailing first, and we remove any other location on the frontend * fix: fixing feature flag (#1069) * feat(FSADT1-1388): Create client for staff Step 1 - BC Registered Business (#1056) * chore: updating config * feat(FSADT1-1388): updated readonly component * feat(FSADT1-1388): added bc registered staff loading * docs: updated stubs * chore: added validation to isNotEmpty to check if string * feat(FSADT1-1388): initial version of bc registered * chore: added new stub * feat(FSADT1-1388): added bc reg validations * feat(FSADT1-1388): added validations to bcreg * test(FSADT1-1388): updated tests and cypress files * chore: added IDs to error notification * chore: small update on submission validator * feat(FSADT1-1388): added match notification This can serve as a base for the fuzzy match notification. The FuzzyMatchNotificationGroupingComponent.vue is the responsible for showing the cds-actionable-notification. It has an ID and it should react/show data only if the received notification is marked for it. This way we can have as many as required throught the entire page and only the one that matches the Id will pop-up. New types were added to match the fuzzy response and some other fuzzy related data. An example on how to use it globally can be seen on the FormStaffPage.vue file. <fuzzy-match-notification-grouping-component id="global" /> sets the "global" one that will apear on top and show a notification, such as for BC Registrered ones. To trigger it check the usage on the BcRegisteredClientInformationWizardStep.vue file around line 172~184. The errorBus.emit is to force the field to show the error message below it. The fuzzyBus is to force the fuzzy notification to appear. The ID used here was the global, so it should make the global one appear only, no other notification should appear. * feat(FSADT1-1388): added bc registered handling for all types added the ability to handle duplicated and enabled the screen to handle possible external invalid cases. * test: updated cypress fixtures and commands * chore: updated staff validation config * test(FSADT1-1388): added more tests * feat(FSADT1-1388): allowing idir to receive responses * test(FSADT1-1388): added test case for 404 * feat(FSADT1-1388): added work safe bc to legacy * fix(FSADT1-1388): added workSafeBCNumber to dto * fix(FSADT1-1388): fixed fuzzy notification * feat(FSADT1-1388): added registered SP staff variation * feat(FSADT1-1388): broaden the doing business as code * chore(FSADT1-1388): added test case name to test * chore: disabling content of another feature * chore: returned value * test: fixing tests * fix: fixing tests * test: fixing test * test: fixing test * test: fixing tests * test: fixing test * feat(FSADT1-1397): Backend Fuzzy matching on Business Information for BC Registered Business (#1065) * feat(FSADT1-1397): renamed cases for registered * fix(FSADT1-1397): added missing cors header * test(FSADT1-1397): added more test util * test(FSADT1-1397): refactored test and added name * test(FSADT1-1397): refactored test and added name * test(FSADT1-1397): added missing test cases * feat(FSADT1-1397): added registered business match * chore: re-enabling match * test: updating tests * chore: updating code * chore: updating stubs * chore: updating validation and test * chore: fixing typo * fix: Fixed the following issue: "Legacy key/value format with whitespace separator should not be used" --------- Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca> * feat(FSADT1-1390): First Nation, Government, Ministry of Forests, and Unregistered Business client types (#1070) * feat(FSADT1-1399): Backend Fuzzy matching for Business Information for Other types (#1071) * feat(FSADT1-1397): renamed cases for registered * fix(FSADT1-1397): added missing cors header * test(FSADT1-1397): added more test util * test(FSADT1-1397): refactored test and added name * test(FSADT1-1397): refactored test and added name * test(FSADT1-1397): added missing test cases * feat(FSADT1-1397): added registered business match * chore: re-enabling match * test: updating tests * chore: updating code * chore: updating stubs * chore: updating validation and test * chore: fixing typo * feat(FSADT1-1399): added first nation example * feat(FSADT1-1399): added first nation matcher * feat(FSADT1-1399): added other matcher * fix(FSADT1-1397): added missing endpoints * fix(FSADT1-1397): added missing endpoints test * test(FSADT1-1399): fixed test matchers * fix(FSADT1-1397): added missing endpoints test * test: fixing tests * feat(FSADT1-1399): updated processor to support other types * feat(FSADT1-1399): added validators * fix: Fixed the following issue: "Legacy key/value format with whitespace separator should not be used" --------- Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca> Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com> * fix(be:FSADT1-1430): Fix submission list filter (#1072) * fix: fixing missing dto for native reflection (#1074) * fix: fixing missing dto for native reflection * fix: fixing missing dto for native reflection * fix: added missing complementary address info * fix(fe): Added missing client types and made code reviews (#1075) fix: Added missing client types and made code reviews * test: re-adding test files (#1076) * fix: fixing missing dto for native reflection * fix: fixing missing dto for native reflection * fix: added missing complementary address info * test: adding missing tests * feat(FSADT1-1353): add Frontend Fuzzy matching on Business information for Individuals (#1073) * auto-fill data manual test * feat: highlight the fields with error * feat: validate fields as a group * feat: highlight fields with warning style * Revert "feat: validate fields as a group" A lot of manual work to resolve conflicts from reverting commit ec169e2. * feat: clear fuzzy errors on fields * fix: remove emit from function * feat: add a simple checkbox component * feat: add the review statement checkbox * feat: skip the fuzzy matching when the errors were already reviewed by the user * fix: provide a default value for the payload * fix: skip notification for client name * fix: remove unused property * Revert "auto-fill data manual test" This reverts commit 431cd55. * test: fuzzy match component * feat: add checkboxId to refer to the inner cds-checkbox * test: fuzzy matching * refactor: client identification group * test: add identification * feat: display identification match * test: Fuzzy Notification Component * fix: limit allowed characters on Acronym * test: add recently removed assertions back * test: fix Acronym test * feat: update validation messages for isIdCharacters * fix: do not skip the fuzzy matching If the user goes back to that step, run it again. * test: remove test that is longer valid * test: remove fake describe/it approach * chore: adding mocks --------- Co-authored-by: Paulo Gomes da Cruz Junior <paulo.cruz@gov.bc.ca> * fix(FSADT1-1431): added security role for districts (#1077) * fix(FSADT1-1415): reordering the client type for staff (#1078) * fix(FSADT1-1415): reordering the client type for staff * test(FSADT1-1415): adding test * chore: resolving missing components * chore: adding env var for test * chore: removing unexisting component --------- Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com> * fix(FSADT1-1435): fixing bug when different countries are on list (#1079) * fix(FSADT1-1415): reordering the client type for staff * test(FSADT1-1415): adding test * chore: resolving missing components * chore: adding env var for test * chore: removing unexisting component * chore: adding missing validators * fix(FSADT1-1435): removing some validations from list --------- Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com> * feat(FSADT1-1429): Unregistered business client type is only viewed b… (#1080) * fix(be:FSADT1-1446): Wrong main address being persisted in Oracle (#1082) * fix(be:FSADT1-1446): Wrong main address being persisted in Oracle * no message * fix(fe): Added missing masks (#1083) Added missing masks and made code review * feat(FSADT1-1396|FSADT1-1398): added frontend fuzzy match for remaining client types (#1081) * chore: adding new flag to match result and changing contact and location setting contact and location as fuzzy true to allow the frontend to deal with its visual, while adding new flag to represent the source of the result * feat(FSADT1-1396): added fuzzy matching for registered business * feat(FSADT1-1396): renaming some fields on fuzzy match * feat(FSADT1-1396): updating fuzzy mock and mappings * test(FSADT1-1396): added tests to individual and registered fuzzy match * test(FSADT1-1398): added tests to other types of fuzzy on step 1 * chore(FSADT1-1396): renaming some fields on fuzzy match * chore(FSADT1-1398): renaming some fields on fuzzy match * fix(FSADT1-1398): fixing test cases * text: fixing failing test * test: reduced the wait time on cypress * chore: added missing intercept * chore: added missing stubs * fix(FSADT1-1396): fixed identification fuzzy * chore: updating fuzzy match * chore(FSADT1-1398): removing pending match for other individual * fix: fixed fuzzy match field association * chore: added missing intercept * test: fixing wrong check on test * fix(FSADT1-1396): fixing field name on grouping * test: fixing test params * chore: removing console log --------- Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com> * fix(be:FSADT1-1449): Fixed order of business search by name (#1084) * feat: testing deploy of legacy db * chore: updating legacy deployment * chore: changing db to legacy oracle * chore: removing volume * chore: changing permission of scripts * chore: updating legacydb file * chore: updated oracle user * chore: updated image * chore: run as * chore: image build * chore: updating oracle * chore: test * chore: building legacy image * chore: deploying os * chore: image update * feat: updated deployment for oracle legacy * chore: changing deployment to tools env * chore: token test * chore: moving to tools * chore: removing temp token * chore: fixing image * chore: forcing all files to be 777 * chore: forcing all files to be 777 * chore: changing the oracle user id * chore: removing files * chore: updating legacy database deploy * chore: updating image * chore: updated init container * chore: updated compose * chore: legacydb test * chore: removed pvc * chore: setting db creation * chore: fixing job * chore: fixing deploy * feat: adding legacydb to pr-open * chore: changing deploy order * chore: split the pr process into two * chore: job renamed * feat: enabled legacy to use flyway - This will allow the legacy app to be able to create its own database structure. - There are safeguards in place to prevent it from running it in prod - It will only be available to dev and local - Migration folder is not default, to prevent issues in other environments - Oracle port will be provided as an argument * fix: fixed flyway for test * chore: changing parameter to string * fix: fixed parameter value * chore: changing profiles origin on legacy * ci: fixed deployment of legacy * ci: aligned deployment to allow connection * ci: updated cert extractor * chore: fixing the host of the database * chore: fixing host name of oracle * chore: updating network policies * chore: updating configurations * chore: updating configurations * chore: updating configurations * chore: updating configurations * chore: updating configurations * chore: converting from deploymentconfig to deployment * chore: fixing deployment * chore: opening the policy * chore(deps): updated deployer for legacydb * chore: increasing resources * feat: adding cron for migration * chore: renaming action * chore: renamed user for legacy due to schema issues * chore: name change * chore: adding migration call * chore: updated resource for oracle * chore: updating deployment * chore: fixing tools migrations * chore: adding close/remove database cleanup --------- Co-authored-by: Derek Roberts <derek.roberts@gmail.com> Co-authored-by: Maria Martinez <77364706+mamartinezmejia@users.noreply.github.com> Co-authored-by: BCGov-NR PR Bot <42219260+bcgov-devops@users.noreply.github.com> Co-authored-by: snyk-bot <snyk-bot@snyk.io> Co-authored-by: Maria Martinez <maria.martinez@gov.bc.ca> Co-authored-by: Fernando Terra <79578735+fterra-encora@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a registered corporation or sole proprietor is added to the staff screen, a fuzzy match should be triggered to check if the data already exists in the system. The fuzzy match for BC registered data should be grouped into distinct groups and then checked against the existing entries. In case of a match, the fuzzy match should return the data pointing out to what entry it matches so that it can be shown.
Type of change
How Has This Been Tested?
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Any successful deployments (not always required) will be available here
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: