Merge pull request #67 from bcgov/feature/SRIS-7

fix incorrect-handling of No selections for protocol19Exemptions attribute
bcgov · Aug 16, 2024 · 5a4e72a · 5a4e72a
2 parents 42027fc + 60d4843
commit 5a4e72a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/helper.py b/helper.py
@@ -682,11 +682,11 @@ def map_source_site(_submission):
         _src_dic['soilStorageType'] = _submission.get(chefs_src_param('soilStorageType'))
 
         if _submission.get(chefs_src_param('exemptionFromProtocol19Apply')) is not None:
-            if _submission.get(chefs_src_param('exemptionFromProtocol19Apply')):
+            if convert_to_yes_no(_submission.get(chefs_src_param('exemptionFromProtocol19Apply'))) == 'Yes':
                 if _submission.get(chefs_src_param('protocol19AppliedExemptions')) is not None:
                     _src_dic['protocol19Exemptions'] = create_source_site_protocol_19_exemptions(_submission, chefs_src_param('protocol19AppliedExemptions'))
             else:
-                _src_dic['protocol19Exemptions'] = 'no'
+                _src_dic['protocol19Exemptions'] = 'No'
 
         create_soil_volumes(
             _submission,