Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor package to remove sharp edges for schema authors/users (particularly @row / Row) and improve API #54

Merged
merged 29 commits into from
Oct 27, 2022
Merged

refactor package to remove sharp edges for schema authors/users (particularly @row / Row) and improve API #54

merged 29 commits into from
Oct 27, 2022

Commits on Aug 9, 2022

  1. Add name and type util functions for schemas

    @OTDE
    OTDE committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    917fbb9 View commit details
    Browse the repository at this point in the history

  2. Add tests for field name/type util functions

    @OTDE
    OTDE committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    4ca4b42 View commit details
    Browse the repository at this point in the history

  3. Invoke generated struct directly

    @OTDE
    OTDE committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    b42e64a View commit details
    Browse the repository at this point in the history

  4. Add dispatch on generated struct type

    @OTDE
    OTDE committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    def1138 View commit details
    Browse the repository at this point in the history

  5. Undo accidental formatting

    @OTDE
    OTDE committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    c4e0bb7 View commit details
    Browse the repository at this point in the history

  6. Use consistent kwarg spacing

    @OTDE
    OTDE committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    304d017 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: Alex Arslan <ararslan@comcast.net>
    @OTDE @ararslan
    OTDE and ararslan committed Aug 9, 2022
    Configuration menu
    Copy the full SHA
    f8a3a13 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. Remove fallback method errors for util functions

    @OTDE
    OTDE committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    cbd1fcf View commit details
    Browse the repository at this point in the history

  2. Merge branch 'sc/column-name-utility-functions' of https://github.com… 

    …/beacon-biosignals/Legolas.jl into sc/column-name-utility-functions
    @OTDE
    OTDE committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    176aa6f View commit details
    Browse the repository at this point in the history

  3. Update tests to expect new error type

    @OTDE
    OTDE committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    1158b56 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2022

  1. refactor

    @jrevels
    jrevels committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    c9d7de5 View commit details
    Browse the repository at this point in the history

  2. fix typo

    @jrevels
    jrevels committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    32b8663 View commit details
    Browse the repository at this point in the history

  3. julia version compat fix

    @jrevels
    jrevels committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    44efde2 View commit details
    Browse the repository at this point in the history

  4. another julia compat fix

    @jrevels
    jrevels committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    3633d12 View commit details
    Browse the repository at this point in the history

  5. make comment consistent with code change

    @jrevels
    jrevels committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    c2ea420 View commit details
    Browse the repository at this point in the history

  6. fix field type escaping and add a test

    @jrevels
    jrevels committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    5c5c044 View commit details
    Browse the repository at this point in the history

  7. fix julia 1.3 compat issue again

    @jrevels
    jrevels committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    6ee2d8d View commit details
    Browse the repository at this point in the history

  8. moar julia 1.3 compat fixes

    @jrevels
    jrevels committed Oct 3, 2022
    Configuration menu
    Copy the full SHA
    2906296 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2022

  1. implement design proposal arising from #54 (#55)

    @jrevels
    jrevels committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    6b968c7 View commit details
    Browse the repository at this point in the history

  2. bump minimum Julia version to latest LTS minor version

    @jrevels
    jrevels committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    f8b48fa View commit details
    Browse the repository at this point in the history

  3. Update src/schemas.jl 

    Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com>
    @jrevels @ericphanson
    jrevels and ericphanson committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    c6c0d57 View commit details
    Browse the repository at this point in the history

  4. Update src/schemas.jl 

    Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com>
    @jrevels @ericphanson
    jrevels and ericphanson committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    53be860 View commit details
    Browse the repository at this point in the history

  5. Update docs/src/schema-concepts.md 

    Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com>
    @jrevels @ericphanson
    jrevels and ericphanson committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    b9eca8a View commit details
    Browse the repository at this point in the history

  6. tweak err msg, fix tests

    @jrevels
    jrevels committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    e3dd4c0 View commit details
    Browse the repository at this point in the history

  7. add additional syntax note

    @jrevels
    jrevels committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    5f8ec57 View commit details
    Browse the repository at this point in the history

  8. make sure to test nested (de)serialization of record types

    @jrevels
    jrevels committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    2fe38fc View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2022

  1. use record type names to drive version declaration, rather than ident… 

    …ifiers
    @jrevels
    jrevels committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    9fe8092 View commit details
    Browse the repository at this point in the history

  2. add a couple more nested serialization tests

    @jrevels
    jrevels committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    7315fd3 View commit details
    Browse the repository at this point in the history

  3. Update docs/src/schema-concepts.md 

    Co-authored-by: Eric Hanson <5846501+ericphanson@users.noreply.github.com>
    @jrevels @ericphanson
    jrevels and ericphanson committed Oct 27, 2022
    Configuration menu
    Copy the full SHA
    e8b0cb4 View commit details
    Browse the repository at this point in the history