add record_type and schema_version_from_record
#78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrevels
changed the title
record_type and schema_version_from_record
jrevels
force-pushed
the
jr/reflection
branch
from
b14f8c0
to
3498667
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are useful for building semi-generic functionality/harnesses atop suites of known
Legolas.SchemaVersions.Note that this purposefully does NOT define/expose a function like
schema_version_from_record_type(::Type{T<:AbstractRecord})::SchemaVersion(though there is an underscore-prefixed function like this that Legolas needs for its own internal codegen usage). We do not intend on exposing this kind of function for reasons similar to those articulated here.