Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add validate_signals/validate_annotations #98

Merged
merged 7 commits into from
Aug 11, 2021
Merged

add validate_signals/validate_annotations #98

merged 7 commits into from
Aug 11, 2021

Conversation

jrevels
Copy link
Member

@jrevels jrevels commented Aug 10, 2021

These new functions provide additional domain-specific inter-row checks in addition to the existing Legolas.validate.

In draft as it still needs tests

src/annotations.jl Outdated Show resolved Hide resolved
src/signals.jl Outdated Show resolved Hide resolved
src/signals.jl Outdated Show resolved Hide resolved
src/signals.jl Outdated Show resolved Hide resolved
src/signals.jl Outdated Show resolved Hide resolved
@@ -9,6 +9,28 @@ function is_lower_snake_case_alphanumeric(x::AbstractString, also_allow=())
all(i -> i in ALPHANUMERIC_SNAKE_CASE_CHARACTERS || i in also_allow, x)
end

# TODO port a generic version of this + notion of primary key to Legolas.jl
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@jrevels jrevels marked this pull request as ready for review August 11, 2021 21:53
@jrevels jrevels merged commit bddf32f into master Aug 11, 2021
@jrevels jrevels deleted the jr/validate branch August 11, 2021 22:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants