Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use PythonCall instead of PyCall #4

Merged
merged 8 commits into from
May 30, 2023
Merged

use PythonCall instead of PyCall #4

merged 8 commits into from
May 30, 2023

Conversation

palday
Copy link
Member

@palday palday commented May 30, 2023

TODO:

  • update README

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #4 (2de76d9) into main (bcce447) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main        #4   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            9         9           
=========================================
  Hits             9         9           
Impacted Files Coverage Δ
src/PyFOOOF.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@palday palday requested a review from mich11 May 30, 2023 16:23
ground_truth = float.(py"$(gauss_params)")
actual_estimates = fm.gaussian_params_
# not worth adding a compat dependency just to get stack() for one test,
# ew this is messy without stack()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

README.md Outdated Show resolved Hide resolved
@@ -80,125 +43,109 @@ julia> using PyFOOOF
julia> fm = PyFOOOF.FOOOF();
```

The PyCall infrastructure also means that Python docstrings are available
The PythonCall infrastructure also means that Python docstrings are available
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

README.md Outdated Show resolved Hide resolved
palday and others added 3 commits May 30, 2023 12:14
Co-authored-by: mich11 <michelle.fogerson@beacon.bio>
@palday palday merged commit 7bb2e90 into main May 30, 2023
@palday palday deleted the pa/pythoncall branch May 30, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants