Use fixed version of ray-project #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennmoy
reviewed
Sep 28, 2023
|
Shoudl we also checkout the same commit in |
Codecov Report
@@ Coverage Diff @@
## main #164 +/- ##
=======================================
Coverage 95.00% 95.00%
=======================================
Files 12 12
Lines 540 540
=======================================
Hits 513 513
Misses 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Initial Docker build is sooo slow: #165 |
glennmoy
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to: #154 (review)
By using a specific commit of
rayin ourbuild_library.jlscript we can ensure that from source builds are full reproducible from any commit (from now on). We could just use theWORKSPACE.bazelto also do this but this allows us the flexibility to develop against a branch via--no-checkout