Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release process follow ups #220
Release process follow ups #220
Changes from 30 commits
d01470e
3e11e3b
931f69d
e24f1f9
7d79350
601f06d
a44a982
36199b5
c24d884
448be44
b7afa56
44a65fa
1c216c1
5a30daa
e67d4b1
88b36c4
46c90b9
71bb53d
3dbbece
1925e53
9fb8585
7fd9341
b8876c3
6271ae8
8916e10
307ba3a
de45f66
290cd7c
ea8304d
ba45577
eaa7341
a8bf476
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious if you verified this? I thought maybe we'd have to do
git fetch --tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup it seems to work https://github.com/beacon-biosignals/Ray.jl/actions/runs/6630217614/job/18011182410?pr=220#step:3:18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we create a tag that isn't a version number this will break. We should do:
and do a string comparison later.
Also, we can simplify this to:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
switching to this action as it allows us to set the rlease as "latest release"