Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON_LENGTH for MySQL #356

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Add JSON_LENGTH for MySQL #356

merged 2 commits into from
Nov 2, 2020

Conversation

MrMitch
Copy link
Contributor

@MrMitch MrMitch commented Oct 2, 2020

This adds support for the JSON_LENGTH function for MySQL.

https://dev.mysql.com/doc/refman/8.0/en/json-attribute-functions.html#function_json-length

Copy link
Contributor

@stevelacey stevelacey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. I think when it's possible to mirror the SQL to the DQL exactly we probably should, see above amends.

@MrMitch
Copy link
Contributor Author

MrMitch commented Oct 3, 2020

Hi @stevelacey, thank you for your feedback. I've rebased the branch on master (since #355 was merged) and applied the changes you proposed (with a slight variation to prevent an error in SqlWalker::walkStringPrimary if $path is null).

@stevelacey stevelacey merged commit 53a71be into beberlei:master Nov 2, 2020
@stevelacey
Copy link
Contributor

@MrMitch thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants