Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ramsey/composer-install #429

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

derrabus
Copy link
Collaborator

@derrabus derrabus commented Feb 5, 2024

The cache we use in our CI for composer dependencies is broken: It generates a hash based on the composer lock file which we don't commit and restores based on the PHP version which leaves us with a stale cache whenever we change the composer.json.

I'd like to delegate installing dependencies to the ramsey/composer-install action instead.

Copy link
Collaborator

@greg0ire greg0ire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please

@derrabus derrabus merged commit 271b3c5 into beberlei:master Feb 5, 2024
7 checks passed
@derrabus derrabus deleted the ci/composer branch February 5, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants