Add missing export-ignore #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While you're at it, can you take inspiration for other Doctrine projects regarding what to add in here? I'm thinking psalm baselines, etc. |
|
@greg0ire I used to look, mostly at ORM, to see what was done and how it was done. This just came up because I did a test composer install and came down with it in the .github folder. Now that you asked, I checked and the wrong version (1.4) was install by composer, so I didn't see everything. There are more problems on dev-master. I'll update it. |
connorhu
force-pushed
the
fix/missing-export-ignore-github
branch
from
c811304
to
1157b82
Compare
connorhu
changed the title
derrabus
approved these changes
Feb 28, 2024
|
Thanks @connorhu ! |
|
In the meantime I found that git archive uses it so I can test it in a local environment. One is always learning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.