Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Enhance %title #3059

Merged
merged 4 commits into from
Nov 29, 2018
Merged

WIP: Enhance %title #3059

merged 4 commits into from
Nov 29, 2018

Conversation

GuilhermeHideki
Copy link
Member

@GuilhermeHideki GuilhermeHideki commented Oct 22, 2018

Fixes #3033

I would like to know if would be better if we had a "smart mode" which lower-case some prepositions, like titlecase does.

  • Tests
  • Documentation
  • Changelog

@sampsyo
Copy link
Member

sampsyo commented Oct 22, 2018

Looks right to me! Thanks for tackling this. AFAICT, the AppVeyor failure above is a fluke.

@GuilhermeHideki
Copy link
Member Author

Rebased on top of master

@GuilhermeHideki GuilhermeHideki merged commit fa1037e into master Nov 29, 2018
@GuilhermeHideki GuilhermeHideki deleted the 3033-title-format-capitalize branch November 29, 2018 13:31
@sampsyo sampsyo added the feature features we would like to implement label Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature features we would like to implement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

%title{ } Capitalize after apostrophe
2 participants