Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra replaygain fields from loudgain #3381

Closed
wants to merge 1 commit into from

Conversation

Moonbase59
Copy link

As discussed in forum, here are the new MediaFile fields to make magic happen in beets.

@jtpavlock
Copy link
Contributor

jtpavlock commented Jul 8, 2020

I think I'm a bit confused, is loudgain supported by beets, or is this PR attempting to preemptively add fields for an unsupported backend component?

@sampsyo
Copy link
Member

sampsyo commented Jul 9, 2020

Indeed; as I mentioned recently in #3368, I've sort of lost the context here.

@jtpavlock
Copy link
Contributor

In that case I'm closing this for now. I think it would also make sense to couple this change with the actual implementation of loudgain

@jtpavlock jtpavlock closed this Jul 9, 2020
@jtpavlock
Copy link
Contributor

jtpavlock commented Jul 9, 2020

Looks like beetbox/mediafile#19 is relevant, which provides the implementation of these fields, but still doesn't make sense unless we actually switch to or add loudgain as a replay gain backend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants