Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Py3.11 to the supported version list. #224

Merged
merged 10 commits into from
Oct 27, 2022
Merged

Add Py3.11 to the supported version list. #224

merged 10 commits into from
Oct 27, 2022

Conversation

freakboy3742
Copy link
Member

Add Python 3.11 to the supported version list.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742
Copy link
Member Author

This should not be merged as is, as Python 3.11 has not been finalised.

This uses the "most recent pre-release" on CI; as soon as 3.11 is finalised, we can update the CI configuration and merge.

Copy link
Collaborator

@dgelessus dgelessus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you for the updates!

setup.cfg Outdated
Comment on lines 18 to 19
Programming Language :: Python :: 3.5
Programming Language :: Python :: 3.6
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 3.5 and 3.6 are still included in the CI and tox configuration, and AFAICT the code is still fully 3.5-compatible, we should keep those versions listed in the metadata too.

@freakboy3742
Copy link
Member Author

Looks like the CI failure on 3.11 is due to actions/setup-python#531.

Copy link
Collaborator

@dgelessus dgelessus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Just curious, what's the motivation for pinning specific minor versions of the GitHub Actions actions? Nothing wrong with doing so probably, but most projects I've seen only request a major/release version.

@freakboy3742 freakboy3742 merged commit 6baaeb0 into main Oct 27, 2022
@freakboy3742 freakboy3742 deleted the py3.11 branch October 27, 2022 23:13
@freakboy3742
Copy link
Member Author

The version pinning is a carry over from the configuration in Briefcase, where we've turned on Dependabot. I'm planning to do the same on this repo (and a couple of others) shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants