Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sphinx-copybutton #1897

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Apr 24, 2023

Changes

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 marked this pull request as ready for review April 25, 2023 00:37
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freakboy3742 freakboy3742 merged commit a579da0 into beeware:main Apr 25, 2023
@rmartin16 rmartin16 deleted the copybutton branch April 25, 2023 23:06
@rmartin16
Copy link
Member Author

@freakboy3742, as a note, since this came up for rubicon. I added the # prompt for Linux root bash sessions; however, this means comments in a code block will get treated as commands. So, we can either remove this proactively now for Briefcase and Toga or just keep it in mind going forward.

@freakboy3742
Copy link
Member

@rmartin16 I missed that detail in the noise of regexes... given that we're only using $ for prompts anyway, my inclination would be to remove # from that regex and avoid the potential confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants