Make headings optional #1981
Closed
Make headings optional #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ayed Also made headings a read-only property, to reflect that changes to it had no effect.
|
Thanks for the PR. We're in the middle of auditing all the widgets at the moment, and Tree will be on the list to look at in the very near future. I'll likely put off reviewing this PR until I'm actively looking at the Tree widget, so I can integrate this into any other changes that need to be made. |
|
This looks really good; however, I've got a bunch of related changes that I need to make as part of the audit of the Tree widget (see #2017), so I'll merge this PR into that one. |
11 tasks
|
Closed in favor of #2017. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headings is now optional for the Tree widget.
If not provided, the widget will not show the header.
Not tested for GTK.
I took the opportunity to migrate the Tree widget tests to pytest, and improve the coverage.
Fixes #1767
PR Checklist: