Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Python 3.7 #2027

Merged
merged 11 commits into from
Jul 10, 2023
Merged

Deprecate Python 3.7 #2027

merged 11 commits into from
Jul 10, 2023

Conversation

freakboy3742
Copy link
Member

Python 3.7 is officially EOL, so we can remove it from the list of tested and officially supported versions.

This is also an opportune time to ensure all the documentation is internally consistent about supported versions etc.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742 freakboy3742 requested a review from mhsmith July 9, 2023 03:15
core/README.rst Outdated
Comment on lines 21 to 24
* If you're on macOS, you need to be on 10.10 (Yosemite) or newer.

Problems with source installs
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
* If you're on Windows, you'll need Windows 10 or newer. If you are using
Windows 10 and want to use a WebView to display web content, you will also
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicating all of this is just giving ourselves extra work to keep it in sync. Suggest replacing it all with:

* For platform-specific requirements, see the READMEs of each backend.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - however, we also need to make sure we consistently link to the actual place where these requirements are specified so we have a single source of truth. I'll take another pass at this.

Comment on lines 39 to 40
* If you're on macOS, you need to be on 10.10 (Yosemite) or newer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue as the other README.

@mhsmith mhsmith merged commit d130fcb into beeware:main Jul 10, 2023
39 checks passed
@freakboy3742 freakboy3742 deleted the goodbye-3.7 branch July 10, 2023 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants