Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a web widget for divider #2051

Merged
merged 4 commits into from
Jul 26, 2023
Merged

Conversation

cgl
Copy link
Contributor

@cgl cgl commented Jul 23, 2023

Prior to this change, the web implementation of divider widget was only implemented as a dummy widget.

This change adds basic implementation of the divider widget and adds it into web factories.

PR Checklist:

  • [ x ] All new features have been tested
  • [ x] All new features have been documented
  • [ x] I have read the CONTRIBUTING.md file
  • [ x] I will abide by the code of conduct

Prior to this change, the web implementation of divider widget was
only implemented as a dummy widget.

This change adds basic implementation of the divider widget and adds
it into web factories.
@cgl cgl marked this pull request as ready for review July 23, 2023 14:59
@freakboy3742
Copy link
Member

FYI: The Linux CI failure will be fixed by #2052. The Android CI failure will be fixed by beeware/briefcase#1380.

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for the contribution!

@freakboy3742 freakboy3742 merged commit 0d94690 into beeware:main Jul 26, 2023
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants