Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Winforms: remove indirect imports #2090

Merged
merged 12 commits into from
Aug 22, 2023
Merged

Winforms: remove indirect imports #2090

merged 12 commits into from
Aug 22, 2023

Conversation

chelseafrost
Copy link
Contributor

@chelseafrost chelseafrost commented Aug 21, 2023 •
edited
Loading

PR Checklist:

  • All new features have been tested
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

freakboy3742
freakboy3742 requested changes Aug 21, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all looking really good; a couple of suggestions and cleanups inline.

winforms/src/toga_winforms/app.py Outdated Show resolved Hide resolved
winforms/src/toga_winforms/fonts.py Outdated Show resolved Hide resolved
winforms/src/toga_winforms/libs/__init__.py Outdated Show resolved Hide resolved
winforms/src/toga_winforms/widgets/canvas.py Outdated Show resolved Hide resolved
winforms/src/toga_winforms/widgets/webview.py Outdated Show resolved Hide resolved
winforms/src/toga_winforms/window.py Outdated Show resolved Hide resolved
winforms/tests_backend/__init__.py Outdated Show resolved Hide resolved
freakboy3742
freakboy3742 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - thanks for the cleanup!

@freakboy3742 freakboy3742 merged commit d66b6bf into beeware:main Aug 22, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Winforms: remove indirect imports
2 participants
@chelseafrost @freakboy3742