Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo on UIDelegate #2127

Merged
merged 3 commits into from
Sep 20, 2023
Merged

typo on UIDelegate #2127

merged 3 commits into from
Sep 20, 2023

Conversation

alibeyram
Copy link
Contributor

UIDelegate was misspelled.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

freakboy3742
freakboy3742 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the report. I've opted to remove the delegate entirely. It's clearly a no-op (since it's assigning the wrong variable right now); if it turns out to be needed in future, we can re-add it.

@freakboy3742 freakboy3742 merged commit 8d798c6 into beeware:main Sep 20, 2023
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alibeyram @freakboy3742