Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post audit cleanup #2160

Merged
merged 16 commits into from
Oct 31, 2023
Merged

Post audit cleanup #2160

merged 16 commits into from
Oct 31, 2023

Conversation

freakboy3742
Copy link
Member

@freakboy3742 freakboy3742 commented Oct 20, 2023

Builds on #2075.

Final cleanups after the completion of the widget audit:

  • Removes the dummy first argument from uses of event handlers
  • Removes the @not_implemented decorators, as the implementation tests are no longer needed.
  • Removes the unittest helpers, as the test suite is now all pytest.
  • Replaces pytest-freezegun with pytest-freezer, due to the lack of maintenance on the former.

All platform should now be running without generating any warnings during testing.

Fixes #2171

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@freakboy3742
Copy link
Member Author

Repeating the comment here so it isn't forgotten - we need to run all the example apps to make sure they're using current APIs once #2075 is finalised.

@freakboy3742
Copy link
Member Author

I've just run and updated all the examples. This picked up a couple of places where testbed tests weren't as robust as they could have been (they were just checking that the handler was invoked, not the arguments on the handler invocation), so those tests have been updated.

@freakboy3742 freakboy3742 merged commit 765b568 into beeware:main Oct 31, 2023
35 checks passed
@freakboy3742 freakboy3742 deleted the post-audit-cleanup branch October 31, 2023 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pytest-freezegun produces warnings in core tests
2 participants