Make container automatically resize on orientation change #2161
Conversation
iOS/src/toga_iOS/container.py
Outdated
| @@ -65,6 +65,7 @@ def __init__(self, content=None, layout_native=None, on_refresh=None): | |||
| super().__init__(content=content, on_refresh=on_refresh) | |||
| self.native = UIView.alloc().init() | |||
| self.native.translatesAutoresizingMaskIntoConstraints = True | |||
| self.native.autoresizingMask = 63 | |||
There was a problem hiding this comment.
What's the significance of this magic number? I presume it's the manifestation of a bunch of internal constants? If so, preference would be to preserve those constants in toga_iOS.libs and reference them here.
There was a problem hiding this comment.
Yeah, makes sense. Made the changes you suggested.
iOS/src/toga_iOS/libs/uikit.py
Outdated
| UIViewAutoresizingFlexibleRightMargin = 1 << 2 | ||
| UIViewAutoresizingFlexibleTopMargin = 1 << 3 | ||
| UIViewAutoresizingFlexibleHeight = 1 << 4 | ||
| UIViewAutoresizingFlexibleBottomMargin = 1 << 5 |
There was a problem hiding this comment.
We've been leaning towards using Enums (e.g., UIViewContentMode above), rather than constants. There are some historical examples that use constants; these generally predate the introduction of Enum support in Rubicon.
There was a problem hiding this comment.
I used intEnum rather than Enum so that the | operator would work without calling .value. Also, note that I renamed UIViewAutoresizingNone to UIViewAutoresizing.NoAutoResizing since I couldn't assign to None. If you think we should handle that issue in another way, let me know.
iOS/src/toga_iOS/container.py
Outdated
| | UIViewAutoresizingFlexibleRightMargin | ||
| | UIViewAutoresizingFlexibleTopMargin | ||
| | UIViewAutoresizingFlexibleHeight | ||
| | UIViewAutoresizingFlexibleBottomMargin |
There was a problem hiding this comment.
Have you got an example that demonstrates why Flexible(Top/Bottom/Left/Right)Margin is needed? Conceptually, it doesn't make sense to me that those should be required - the margins should always be 0 an fixed; and from my own testing, masking FlexibleWidth and FlexibleHeight seems to be sufficient.
There was a problem hiding this comment.
Yeah I didn't notice any issues with just FlexibleWidth and FlexibleHeight so I removed the other ones.
This sets the autoResizingMask property of the container.native UIView so that all possible resizing options (i.e. margin, height, and width) are set.
On iOS14 and iOS15 the container.native UIView doesn't always resize properly on orientation change. This is not a problem on iOS16 and iOS17 for some reason. You can see this behavior on the positron-django example.
PR Checklist: