Add support for BenchmarkDotNet #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
now we're in line with the other languages
|
Oh nice, thanks for doing this rebase! |
|
Would you mind updating the test project to .NET SDK 6, since that's the LTS now? All that should be required is to find/replace 3.1.201 with 6.0.101. |
|
@baronfel sure thing! |
|
My bad on the clumsiness regarding the failed build pipeline. I fixed the compiler errors, ran the tests, and ran npm run build. Should be fine now. |
|
Thanks @cabauman for fixing the issues. I'll have a look at the changes over the weekend |
ktrz
requested changes
Feb 14, 2022
- Remove unused parts of interface - Reduce volume of test data - Replace PERSONAL_GITHUB_TOKEN with GITHUB_TOKEN
|
Changes made! Let me know if you find anything else. I stripped the json down by about 1000 lines, but if you want me to go ahead and remove the rest of the non-essential content, I don't mind. |
|
PR looks great! Please just run |
|
Oops. Yes, of course. |
ktrz
reviewed
Feb 17, 2022
ktrz
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased version of #34, so all credit goes to baronfel
I went ahead and updated the supported tools in the README and action.yml file as well. Let me know if there are any other changes you'd like me to make. What should I do about the broken benchmarkdotnet badge images?
resolves #33