Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support benchmark results with decimal dot #3

Merged
merged 1 commit into from
Dec 23, 2019

Conversation

Bnaya
Copy link
Contributor

@Bnaya Bnaya commented Dec 21, 2019

benchmarkjs may have results with decimal dot
For example:
createObjectBuffer with 200 comments x 81.61 ops/sec ±1.70% (69 runs sampled)

benchmarkjs may have results with decimal dot
For example:
`createObjectBuffer with 200 comments x 81.61 ops/sec ±1.70% (69 runs sampled)`
@Bnaya
Copy link
Contributor Author

Bnaya commented Dec 21, 2019

Tests are passing. not sure why the other checks fails.
problem with prev commits?

@rhysd rhysd merged commit a8c46e7 into benchmark-action:master Dec 23, 2019
@rhysd
Copy link
Member

rhysd commented Dec 23, 2019

@Bnaya Thanks!

@rhysd
Copy link
Member

rhysd commented Dec 23, 2019

problem with prev commits?

Yeah, your changes were perfect.
This action is basically for your own branch because it modifies gh-pages branch. (Otherwise, if on: pull_request is allowed, PR branch can modify your repository's branch directly). So I check this action on: push event only. It works fine with the event, but I did not check on: pull_request event. Let me check it when I have time to look into.

@rhysd
Copy link
Member

rhysd commented Dec 23, 2019

This action is basically for your own branch because it modifies gh-pages branch. (Otherwise, if on: pull_request is allowed, PR branch can modify your repository's branch directly). So I check this action on: push event only. It works fine with the event, but I did not check on: pull_request event. Let me check it when I have time to look into.

I fixed this on master branch so CI would not fail on next pull request.

@Bnaya Bnaya deleted the support-decimal-dot branch December 23, 2019 11:57
@Bnaya
Copy link
Contributor Author

Bnaya commented Dec 23, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants