Add support for catch2 benchmarks #6
Conversation
|
Thank you! I'll review this. BTW would you ignore the CI failure? I think it is a bug of validation script which does not consider the initial state of benchmark file. |
|
TODO(@rhysd)
|
| if ( | ||
| ret.every(function(r) { | ||
| return r.range == '' && r.unit == ''; | ||
| }) |
There was a problem hiding this comment.
Since we should verify all elements have valid values here, I think following is correct:
ret.some(function(r) {
return r.range === '' || r.unit === '';
})EDIT: Oh, and please use === for equality. == should never be used for JS/TS :)
There was a problem hiding this comment.
You are of course correct. Thanks for the hint about ===, as this is the first time I touched TS/JS such hints are very welcome. The fix is underway.
There was a problem hiding this comment.
In case you don't know the detail, == is very loose since it permits implicit conversion in operands: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Comparison_Operators#Equality
Please never mind about you're not familiar with JS/TS. Thank you for diving into a new language for contributing this repository!
|
I enabled |
|
Sure, I will check the failing |
|
If you installed all dependencies with |
|
Notification: This was released at v1.7.0. https://github.com/rhysd/github-action-benchmark/releases/tag/v1.7.0 |
Added support for benchmarks produced by the catch2 framework. Unfortunately the output is not very parser-friendly, so the implementation is not so nice.
To get CI to run on my repo I had to manually add a first set of data to the gh-pages, so CI might not run out of the box