Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events for lightboxWillOpen and lightboxWillClose #20

Merged
merged 1 commit into from
Apr 3, 2017

Conversation

ValYouW
Copy link
Contributor

@ValYouW ValYouW commented Apr 3, 2017

Hi,

Added events to be fired before opening the lightbox and before closing the lightbox.
The lightboxWillOpen event passes as arg the relevant image index. This is necessary when using the customControls property of lightbox, we need to know what is the current displayed image so any operation from the custom controls will be run on it.

The lightboxWillClose event is... not necessary but added if for the sake of completion :)
Thx

@benhowell benhowell merged commit 6ba5678 into benhowell:master Apr 3, 2017
@benhowell
Copy link
Owner

Thanks very much @ValYouW. Merged!
Your additions have been released in v0.3.1 👍

@ValYouW
Copy link
Contributor Author

ValYouW commented Apr 4, 2017

@benhowell Thank you

@benhowell
Copy link
Owner

@ValYouW FYI... at least one person has found lightboxWillClose necessary... you just never know!
#34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants